Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add max three app name status for agent control health check #1291

Merged
merged 6 commits into from
Jan 28, 2025
Merged

Add max three app name status for agent control health check #1291

merged 6 commits into from
Jan 28, 2025

Conversation

umaannamalai
Copy link
Contributor

This PR adds a new status code to the agent that sets health check reporting to unhealthy when a user has configured more than 3 app names.

@umaannamalai umaannamalai requested a review from a team as a code owner January 27, 2025 18:38
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 27, 2025 •
edited
Loading

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON bandit 2 0 6.62s
✅ PYTHON black 3 1 0 4.84s
✅ PYTHON flake8 3 0 1.09s
✅ PYTHON isort 3 3 0 0.27s
✅ PYTHON pylint 3 0 7.01s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.72%. Comparing base (3af452b) to head (034b6e7).
Report is 61 commits behind head on super-agent.

Files with missing lines Patch % Lines
newrelic/core/agent_control_health.py 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@               Coverage Diff               @@
##           super-agent    #1291      +/-   ##
===============================================
- Coverage        79.74%   79.72%   -0.02%     
===============================================
  Files              202      202              
  Lines            22352    22360       +8     
  Branches          3545     3546       +1     
===============================================
+ Hits             17825    17827       +2     
- Misses            3370     3372       +2     
- Partials          1157     1161       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hmstepanek
hmstepanek approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@hmstepanek hmstepanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's one linter issue but otherwise looks good to me:

newrelic/core/agent_control_health.py:68:1: E302 expected 2 blank lines, found 1

@umaannamalai umaannamalai merged commit 251fb13 into super-agent Jan 28, 2025
2 checks passed
@umaannamalai umaannamalai deleted the check-multi-app-names branch January 28, 2025 23:54
@mergify mergify bot removed the tests-failing label Jan 28, 2025
@umaannamalai umaannamalai added this to the v10.5.0 milestone Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmstepanek hmstepanek hmstepanek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v10.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@umaannamalai @codecov-commenter @hmstepanek